Skip to content

Shared: Refactor DataFlowStack #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Shared: Refactor DataFlowStack #157

merged 3 commits into from
Jan 30, 2025

Conversation

MathiasVP
Copy link
Collaborator

This changes the DataFlowStack library so that we don't depend on our own modifications to the shared dataflow library.

This has caused us quite a lot of pain in the past. Hopefully we can avoid doing such modifications in t he future.

Commit-by-commit review recommended:

  • The first commit gets rid of the Microsoft modifications to the GitHub dataflow files. It turns out that we have resolved merge conflicts incorrect for some languages for almost 6 months. So many of the files were actually very very old that wasn't being kept up-to-date with the latest developments on the GitHub side 😅 Hopefully we should only have clean merges from now on!
  • The second commit autoformats the DataFlowStack library to make the diff of the last file smaller
  • The last commit does the actual refactoring. Sadly, I had to duplicate some of the code to handle both taint-tracking and dataflow configurations. We can revisit this in the future.

@dilanbhalla dilanbhalla merged commit ee6624a into main Jan 30, 2025
8 checks passed
dilanbhalla added a commit that referenced this pull request Jan 30, 2025
MathiasVP added a commit that referenced this pull request Jan 31, 2025
Java: Update file that was forgotten in #157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants